Skip to content

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Jul 19, 2025

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 19, 2025
@ognevny ognevny changed the title Opt dist stage0 root opt-dist: add an option for setting path to stage0 root Jul 19, 2025
@ognevny ognevny marked this pull request as ready for review July 19, 2025 06:49
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2025

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@ognevny ognevny force-pushed the opt-dist-stage0-root branch 2 times, most recently from 38f8102 to 0d8e7c1 Compare July 21, 2025 12:38
@ognevny
Copy link
Contributor Author

ognevny commented Jul 21, 2025

@Kobzol rebased

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try.

@bors try

@Kobzol
Copy link
Member

Kobzol commented Jul 21, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

⌛ Trying commit 0d8e7c1 with merge d14f82b

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 21, 2025
 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->
r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

💔 Test failed

@ognevny
Copy link
Contributor Author

ognevny commented Jul 21, 2025

oh I see

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
@ognevny ognevny force-pushed the opt-dist-stage0-root branch from 0d8e7c1 to fa92464 Compare July 21, 2025 12:58
@Kobzol
Copy link
Member

Kobzol commented Jul 21, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

⌛ Trying commit fa92464 with merge b5b89d4

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 21, 2025
 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->
r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@rust-bors
Copy link

rust-bors bot commented Jul 21, 2025

☀️ Try build successful (CI)
Build commit: b5b89d4 (b5b89d44539e233a14d265614e2cbe813ba7443c, parent: 67819923ac8ea353aaa775303f4c3aacbf41d010)

@Kobzol
Copy link
Member

Kobzol commented Jul 21, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit fa92464 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
…bzol

 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
bors added a commit that referenced this pull request Jul 22, 2025
Rollup of 8 pull requests

Successful merges:

 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 22, 2025
Rollup of 7 pull requests

Successful merges:

 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5c9a37f into rust-lang:master Jul 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 22, 2025
rust-timer added a commit that referenced this pull request Jul 22, 2025
Rollup merge of #144164 - ognevny:opt-dist-stage0-root, r=Kobzol

 opt-dist: add an option for setting path to stage0 root

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@ognevny ognevny deleted the opt-dist-stage0-root branch July 26, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants